[SYCL] Simplify secondary queue usage #18642
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following KhronosGroup/SYCL-Docs#811, the SYCL 2020 specification will not mandate the use nor exception checking of secondary queues. This allows us to relax the interfaces taking a secondary queue to fully ignore it. This commit drops the passing of the secondary queue throughout the pipeline. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| /// \param CodeLoc is the code location of the submit call (default argument) | ||
| /// \return a SYCL event object, which corresponds to the queue the command | ||
| /// group is being enqueued on. | ||
| template <typename T> | ||
| std::enable_if_t<std::is_invocable_r_v<void, T, handler &>, event> submit( | ||
| T CGF, queue &SecondaryQueue, | ||
| T CGF, queue &, |
There was a problem hiding this comment.
I'd prefer queue & /*SecondaryQueue*/ or [[maybe_unused]] queue &SecondaryQueue. Also, I think the doc string needs to be kept and updated saying we ignore the parameter and that is valid per the specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following KhronosGroup/SYCL-Docs#811, the SYCL 2020 specification will not mandate the use nor exception checking of secondary queues. This allows us to relax the interfaces taking a secondary queue to fully ignore it. This commit drops the passing of the secondary queue throughout the pipeline.